Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APPS-3065 Refactor TagLabels Parsing Logic #69

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Nov 14, 2024

Connected to APPS-3065

Page Updated:

  • pages/events/[slug].vue
  • pages/series/[slug].vue

Notes:

  • Extracted repeating/reused logic for parsing tagLabels into a utility function.

Previews:

Checklist:

  • I added github label for semantic versioning
  • I assigned this PR to someone to review
  • [ ] I double checked it looks like the designs
  • [ ] I completed any required mobile breakpoint styling
  • [ ] I completed any required hover state styling
  • [ ] I included a working spec file
  • [ ] I added notes above about how long it took to build this component
  • [ ] UX has reviewed this PR

@tinuola tinuola added the fix label Nov 14, 2024
@tinuola tinuola self-assigned this Nov 14, 2024
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

🚀 Deployed on https://deploy-preview-69--test-ftva.netlify.app

Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the refactor and also great attention to detail. 🥇

@tinuola tinuola merged commit 2e018b5 into main Nov 14, 2024
18 checks passed
@tinuola tinuola deleted the APPS-3065_refactor-tagLabels-logic branch November 14, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants